Skip to content

Add left and right margin to center about container #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from Feb 14, 2021
Merged

Add left and right margin to center about container #1275

merged 5 commits into from Feb 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2021

This pull request adds left/right margins to the content on the about pages. It centers the page content to make it easier to read on smaller devices.

Tablet

image

Phone

image

I opted to use the pure-css classes rather than altering the css.

Addresses #1273

@jyn514 jyn514 added A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Feb 13, 2021
@jyn514 jyn514 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Feb 13, 2021
@jyn514
Copy link
Member

jyn514 commented Feb 13, 2021

@Liberatys this looks good to me once you revert the whitespace changes :)

@jyn514 jyn514 merged commit cc1b0c7 into rust-lang:master Feb 14, 2021
@jyn514 jyn514 mentioned this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend S-waiting-on-author Status: This PR is incomplete or needs to address review comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant